Skip to content

Commit e8ca461

Browse files
dangowrtkuba-moo
authored andcommitted
net: pcs: pcs-mtk-lynxi: report in-band capability for 2500Base-X
It turns out that 2500Base-X actually works fine with in-band status on MediaTek's LynxI PCS -- I wrongly concluded it didn't because it is broken in all the copper SFP modules and GPON sticks I used for testing. Hence report LINK_INBAND_ENABLE also for 2500Base-X mode. This reverts most of commit a003c38 ("net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities"). The removal of the QSGMII interface mode was correct and is left untouched. Link: openwrt/openwrt#21436 Fixes: a003c38 ("net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities") Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: https://patch.msgid.link/b1cf26157b63fee838be09ae810497fb22fd8104.1768961746.git.daniel@makrotopia.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 5d5fe8b commit e8ca461

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/net/pcs/pcs-mtk-lynxi.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,10 @@ static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs,
9393
{
9494
switch (interface) {
9595
case PHY_INTERFACE_MODE_1000BASEX:
96+
case PHY_INTERFACE_MODE_2500BASEX:
9697
case PHY_INTERFACE_MODE_SGMII:
9798
return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE;
9899

99-
case PHY_INTERFACE_MODE_2500BASEX:
100-
return LINK_INBAND_DISABLE;
101-
102100
default:
103101
return 0;
104102
}

0 commit comments

Comments
 (0)