pwm: stm32: Don't modify HW state in .remove() callback

Uwe Kleine-König · thierryreding · commit e9c2f69aac05 · 2023-07-28T09:46:21.000+02:00
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

Signed-off-by: Uwe Kleine-König &lt;u.kleine-koenig@pengutronix.de&gt;
Signed-off-by: Thierry Reding &lt;thierry.reding@gmail.com&gt;
diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c
@@ -649,10 +649,6 @@ static int stm32_pwm_probe(struct platform_device *pdev)
 static void stm32_pwm_remove(struct platform_device *pdev)
 {
 	struct stm32_pwm *priv = platform_get_drvdata(pdev);
-	unsigned int i;
-
-	for (i = 0; i < priv->chip.npwm; i++)
-		pwm_disable(&priv->chip.pwms[i]);
 
 	pwmchip_remove(&priv->chip);
 }

Original file line number	Diff line number	Diff line change
`@@ -649,10 +649,6 @@ static int stm32_pwm_probe(struct platform_device *pdev)`
`649`	`649`	`static void stm32_pwm_remove(struct platform_device *pdev)`
`650`	`650`	`{`
`651`	`651`	`struct stm32_pwm *priv = platform_get_drvdata(pdev);`
`652`		`- unsigned int i;`
`653`		`-`
`654`		`- for (i = 0; i < priv->chip.npwm; i++)`
`655`		`- pwm_disable(&priv->chip.pwms[i]);`
`656`	`652`
`657`	`653`	`pwmchip_remove(&priv->chip);`
`658`	`654`	`}`