Skip to content

Commit e9c74f8

Browse files
JuliaLawallkuba-moo
authored andcommitted
net: mana: use vmalloc_array and vcalloc
Use vmalloc_array and vcalloc to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // <smpl> @initialize:ocaml@ @@ let rename alloc = match alloc with "vmalloc" -> "vmalloc_array" | "vzalloc" -> "vcalloc" | _ -> failwith "unknown" @@ size_t e1,e2; constant C1, C2; expression E1, E2, COUNT, x1, x2, x3; typedef u8; typedef __u8; type t = {u8,__u8,char,unsigned char}; identifier alloc = {vmalloc,vzalloc}; fresh identifier realloc = script:ocaml(alloc) { rename alloc }; @@ ( alloc(x1*x2*x3) | alloc(C1 * C2) | alloc((sizeof(t)) * (COUNT), ...) | - alloc((e1) * (e2)) + realloc(e1, e2) | - alloc((e1) * (COUNT)) + realloc(COUNT, e1) | - alloc((E1) * (E2)) + realloc(E1, E2) ) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Link: https://lore.kernel.org/r/20230627144339.144478-23-Julia.Lawall@inria.fr Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent fa87c54 commit e9c74f8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/microsoft/mana/hw_channel.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ static int mana_hwc_establish_channel(struct gdma_context *gc, u16 *q_depth,
627627
if (WARN_ON(cq->id >= gc->max_num_cqs))
628628
return -EPROTO;
629629

630-
gc->cq_table = vzalloc(gc->max_num_cqs * sizeof(struct gdma_queue *));
630+
gc->cq_table = vcalloc(gc->max_num_cqs, sizeof(struct gdma_queue *));
631631
if (!gc->cq_table)
632632
return -ENOMEM;
633633

0 commit comments

Comments
 (0)