Skip to content

Commit e9d5ae8

Browse files
drobson-imgtecmripard
authored andcommitted
drm/imagination: Removed unused functions in pvr_fw_trace
Fixing the warning below due to an unused file level vtable. Removing only this causes additional warnings for the now unused functions, so I've removed those too. >> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_trace_group_mask_fops' defined but not used [-Wunused-const-variable=] 205 | static const struct file_operations pvr_fw_trace_group_mask_fops = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Changes since v1: - Corrected hash in Fixes tag. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@intel.com/ Fixes: cb56cd6 ("drm/imagination: Add firmware trace to debugfs") Signed-off-by: Donald Robson <donald.robson@imgtec.com> Signed-off-by: Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231204151337.60930-1-donald.robson@imgtec.com
1 parent aa5d7cf commit e9d5ae8

1 file changed

Lines changed: 0 additions & 44 deletions

File tree

drivers/gpu/drm/imagination/pvr_fw_trace.c

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -167,50 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask)
167167

168168
#if defined(CONFIG_DEBUG_FS)
169169

170-
static int fw_trace_group_mask_show(struct seq_file *m, void *data)
171-
{
172-
struct pvr_device *pvr_dev = m->private;
173-
174-
seq_printf(m, "%08x\n", pvr_dev->fw_dev.fw_trace.group_mask);
175-
176-
return 0;
177-
}
178-
179-
static int fw_trace_group_mask_open(struct inode *inode, struct file *file)
180-
{
181-
return single_open(file, fw_trace_group_mask_show, inode->i_private);
182-
}
183-
184-
static ssize_t fw_trace_group_mask_write(struct file *file, const char __user *ubuf, size_t len,
185-
loff_t *offp)
186-
{
187-
struct seq_file *m = file->private_data;
188-
struct pvr_device *pvr_dev = m->private;
189-
u32 new_group_mask;
190-
int err;
191-
192-
err = kstrtouint_from_user(ubuf, len, 0, &new_group_mask);
193-
if (err)
194-
return err;
195-
196-
err = update_logtype(pvr_dev, new_group_mask);
197-
if (err)
198-
return err;
199-
200-
pvr_dev->fw_dev.fw_trace.group_mask = new_group_mask;
201-
202-
return (ssize_t)len;
203-
}
204-
205-
static const struct file_operations pvr_fw_trace_group_mask_fops = {
206-
.owner = THIS_MODULE,
207-
.open = fw_trace_group_mask_open,
208-
.read = seq_read,
209-
.write = fw_trace_group_mask_write,
210-
.llseek = default_llseek,
211-
.release = single_release,
212-
};
213-
214170
struct pvr_fw_trace_seq_data {
215171
/** @buffer: Pointer to copy of trace data. */
216172
u32 *buffer;

0 commit comments

Comments
 (0)