@@ -213,7 +213,7 @@ enum tb_link_width {
213213 * queried first
214214 * @service_ids: Used to generate IDs for the services
215215 * @in_hopids: Input HopIDs for DMA tunneling
216- * @out_hopids; Output HopIDs for DMA tunneling
216+ * @out_hopids: Output HopIDs for DMA tunneling
217217 * @local_property_block: Local block of properties
218218 * @local_property_block_gen: Generation of @local_property_block
219219 * @local_property_block_len: Length of the @local_property_block in dwords
@@ -356,7 +356,7 @@ int tb_xdomain_request(struct tb_xdomain *xd, const void *request,
356356 unsigned int timeout_msec );
357357
358358/**
359- * tb_protocol_handler - Protocol specific handler
359+ * struct tb_protocol_handler - Protocol specific handler
360360 * @uuid: XDomain messages with this UUID are dispatched to this handler
361361 * @callback: Callback called with the XDomain message. Returning %1
362362 * here tells the XDomain core that the message was handled
@@ -437,7 +437,7 @@ static inline struct tb_service *tb_to_service(struct device *dev)
437437}
438438
439439/**
440- * tb_service_driver - Thunderbolt service driver
440+ * struct tb_service_driver - Thunderbolt service driver
441441 * @driver: Driver structure
442442 * @probe: Called when the driver is probed
443443 * @remove: Called when the driver is removed (optional)
@@ -519,6 +519,7 @@ struct tb_nhi {
519519 * @head: Head of the ring (write next descriptor here)
520520 * @tail: Tail of the ring (complete next descriptor here)
521521 * @descriptors: Allocated descriptors for this ring
522+ * @descriptors_dma: DMA address of descriptors for this ring
522523 * @queue: Queue holding frames to be transferred over this ring
523524 * @in_flight: Queue holding frames that are currently in flight
524525 * @work: Interrupt work structure
@@ -571,12 +572,12 @@ typedef void (*ring_cb)(struct tb_ring *, struct ring_frame *, bool canceled);
571572
572573/**
573574 * enum ring_desc_flags - Flags for DMA ring descriptor
574- * % RING_DESC_ISOCH: Enable isonchronous DMA (Tx only)
575- * % RING_DESC_CRC_ERROR: In frame mode CRC check failed for the frame (Rx only)
576- * % RING_DESC_COMPLETED: Descriptor completed (set by NHI)
577- * % RING_DESC_POSTED: Always set this
578- * % RING_DESC_BUFFER_OVERRUN: RX buffer overrun
579- * % RING_DESC_INTERRUPT: Request an interrupt on completion
575+ * @ RING_DESC_ISOCH: Enable isonchronous DMA (Tx only)
576+ * @ RING_DESC_CRC_ERROR: In frame mode CRC check failed for the frame (Rx only)
577+ * @ RING_DESC_COMPLETED: Descriptor completed (set by NHI)
578+ * @ RING_DESC_POSTED: Always set this
579+ * @ RING_DESC_BUFFER_OVERRUN: RX buffer overrun
580+ * @ RING_DESC_INTERRUPT: Request an interrupt on completion
580581 */
581582enum ring_desc_flags {
582583 RING_DESC_ISOCH = 0x1 ,
@@ -636,7 +637,7 @@ int __tb_ring_enqueue(struct tb_ring *ring, struct ring_frame *frame);
636637 * If ring_stop() is called after the packet has been enqueued
637638 * @frame->callback will be called with canceled set to true.
638639 *
639- * Return: Returns %-ESHUTDOWN if ring_stop has been called. Zero otherwise.
640+ * Return: %-ESHUTDOWN if ring_stop() has been called, %0 otherwise.
640641 */
641642static inline int tb_ring_rx (struct tb_ring * ring , struct ring_frame * frame )
642643{
@@ -657,7 +658,7 @@ static inline int tb_ring_rx(struct tb_ring *ring, struct ring_frame *frame)
657658 * If ring_stop() is called after the packet has been enqueued @frame->callback
658659 * will be called with canceled set to true.
659660 *
660- * Return: Returns %-ESHUTDOWN if ring_stop has been called. Zero otherwise.
661+ * Return: %-ESHUTDOWN if ring_stop has been called, %0 otherwise.
661662 */
662663static inline int tb_ring_tx (struct tb_ring * ring , struct ring_frame * frame )
663664{
@@ -675,6 +676,8 @@ void tb_ring_poll_complete(struct tb_ring *ring);
675676 *
676677 * Use this function when you are mapping DMA for buffers that are
677678 * passed to the ring for sending/receiving.
679+ *
680+ * Return: Pointer to device used for DMA mapping.
678681 */
679682static inline struct device * tb_ring_dma_device (struct tb_ring * ring )
680683{
0 commit comments