Skip to content

Commit ea90034

Browse files
tombamchehab
authored andcommitted
media: i2c: ds90ub913: Fix use of uninitialized variables
smatch reports some uninitialized variables: drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v1'. drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v2'. These are used only for printing debug information, and the use of an uninitialized variable only happens if an i2c transaction has failed, which will print an error. Thus, fix the errors just by initializing the variables to 0. Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/ Fixes: c158d0d ("media: i2c: add DS90UB913 driver") Reported-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent b8e277b commit ea90034

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/media/i2c/ds90ub913.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ static int ub913_log_status(struct v4l2_subdev *sd)
471471
{
472472
struct ub913_data *priv = sd_to_ub913(sd);
473473
struct device *dev = &priv->client->dev;
474-
u8 v = 0, v1, v2;
474+
u8 v = 0, v1 = 0, v2 = 0;
475475

476476
ub913_read(priv, UB913_REG_MODE_SEL, &v);
477477
dev_info(dev, "MODE_SEL %#02x\n", v);

0 commit comments

Comments
 (0)