Skip to content

Commit eabb149

Browse files
vladimirolteandavem330
authored andcommitted
net: dsa: tag_ocelot: do not rely on skb_mac_header() for VLAN xmit
skb_mac_header() will no longer be available in the TX path when reverting commit 6d1ccff ("net: reset mac header in dev_start_xmit()"). As preparation for that, let's use skb_vlan_eth_hdr() to get to the VLAN header instead, which assumes it's located at skb->data (assumption which holds true here). Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent e2fdfd7 commit eabb149

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/dsa/tag_ocelot.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ static void ocelot_xmit_get_vlan_info(struct sk_buff *skb, struct dsa_port *dp,
2626
return;
2727
}
2828

29-
hdr = (struct vlan_ethhdr *)skb_mac_header(skb);
29+
hdr = skb_vlan_eth_hdr(skb);
3030
br_vlan_get_proto(br, &proto);
3131

3232
if (ntohs(hdr->h_vlan_proto) == proto) {

0 commit comments

Comments
 (0)