Skip to content

Commit eac1183

Browse files
Bartosz GolaszewskiLinus Walleij
authored andcommitted
pinctrl: ingenic: use new GPIO line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Acked-by: Paul Cercueil <paul@crapouillou.net> Link: https://lore.kernel.org/20250424-gpiochip-set-rv-pinctrl-part2-v1-6-504f91120b99@linaro.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 43c8981 commit eac1183

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

drivers/pinctrl/pinctrl-ingenic.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3800,12 +3800,14 @@ static void ingenic_gpio_irq_handler(struct irq_desc *desc)
38003800
chained_irq_exit(irq_chip, desc);
38013801
}
38023802

3803-
static void ingenic_gpio_set(struct gpio_chip *gc,
3804-
unsigned int offset, int value)
3803+
static int ingenic_gpio_set(struct gpio_chip *gc, unsigned int offset,
3804+
int value)
38053805
{
38063806
struct ingenic_gpio_chip *jzgc = gpiochip_get_data(gc);
38073807

38083808
ingenic_gpio_set_value(jzgc, offset, value);
3809+
3810+
return 0;
38093811
}
38103812

38113813
static int ingenic_gpio_get(struct gpio_chip *gc, unsigned int offset)
@@ -4449,7 +4451,7 @@ static int __init ingenic_gpio_probe(struct ingenic_pinctrl *jzpc,
44494451
jzgc->gc.fwnode = fwnode;
44504452
jzgc->gc.owner = THIS_MODULE;
44514453

4452-
jzgc->gc.set = ingenic_gpio_set;
4454+
jzgc->gc.set_rv = ingenic_gpio_set;
44534455
jzgc->gc.get = ingenic_gpio_get;
44544456
jzgc->gc.direction_input = pinctrl_gpio_direction_input;
44554457
jzgc->gc.direction_output = ingenic_gpio_direction_output;

0 commit comments

Comments
 (0)