smack: Remove redundant assignments

orzelmichal · cschaufler · commit eaff451d4b7c · 2022-05-23T11:12:08.000-07:00
Get rid of redundant assignments which end up in values not being
read either because they are overwritten or the function ends.

Reported by clang-tidy [deadcode.DeadStores]

Signed-off-by: Michal Orzel &lt;michalorzel.eng@gmail.com&gt;
Signed-off-by: Casey Schaufler &lt;casey@schaufler-ca.com&gt;
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
@@ -1192,7 +1192,6 @@ static ssize_t smk_write_net4addr(struct file *file, const char __user *buf,
 			rc = -EINVAL;
 			goto free_out;
 		}
-		m = BEBITS;
 		masks = 32;
 	}
 	if (masks > BEBITS) {

Original file line number	Diff line number	Diff line change
`@@ -1192,7 +1192,6 @@ static ssize_t smk_write_net4addr(struct file file, const char __user buf,`
`1192`	`1192`	`rc = -EINVAL;`
`1193`	`1193`	`goto free_out;`
`1194`	`1194`	`}`
`1195`		`- m = BEBITS;`
`1196`	`1195`	`masks = 32;`
`1197`	`1196`	`}`
`1198`	`1197`	`if (masks > BEBITS) {`