Skip to content

Commit eb183b2

Browse files
committed
Revert "perf/arm_dmc620: Remove duplicate format attribute #defines"
This reverts commit a5f4ca6. Pulling in the Arm-specific 'linux/perf/arm_pmu.h' header breaks the allmodconfig build for x86: > In file included from drivers/perf/arm_dmc620_pmu.c:26: > include/linux/perf/arm_pmu.h:15:10: fatal error: asm/cputype.h: No such file or directory > 15 | #include <asm/cputype.h> > | ^~~~~~~~~~~~~~~ Just put things back like they were so that the driver can continue to be compile-tested on a variety of architectures. Link: https://lore.kernel.org/r/20231213100931.12d9d85e@canb.auug.org.au Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Will Deacon <will@kernel.org>
1 parent bd69063 commit eb183b2

1 file changed

Lines changed: 21 additions & 1 deletion

File tree

drivers/perf/arm_dmc620_pmu.c

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include <linux/module.h>
2424
#include <linux/mutex.h>
2525
#include <linux/perf_event.h>
26-
#include <linux/perf/arm_pmu.h>
2726
#include <linux/platform_device.h>
2827
#include <linux/printk.h>
2928
#include <linux/rculist.h>
@@ -190,6 +189,27 @@ static const struct attribute_group dmc620_pmu_events_attr_group = {
190189
#define ATTR_CFG_FLD_clkdiv2_LO 9
191190
#define ATTR_CFG_FLD_clkdiv2_HI 9
192191

192+
#define __GEN_PMU_FORMAT_ATTR(cfg, lo, hi) \
193+
(lo) == (hi) ? #cfg ":" #lo "\n" : #cfg ":" #lo "-" #hi
194+
195+
#define _GEN_PMU_FORMAT_ATTR(cfg, lo, hi) \
196+
__GEN_PMU_FORMAT_ATTR(cfg, lo, hi)
197+
198+
#define GEN_PMU_FORMAT_ATTR(name) \
199+
PMU_FORMAT_ATTR(name, \
200+
_GEN_PMU_FORMAT_ATTR(ATTR_CFG_FLD_##name##_CFG, \
201+
ATTR_CFG_FLD_##name##_LO, \
202+
ATTR_CFG_FLD_##name##_HI))
203+
204+
#define _ATTR_CFG_GET_FLD(attr, cfg, lo, hi) \
205+
((((attr)->cfg) >> lo) & GENMASK_ULL(hi - lo, 0))
206+
207+
#define ATTR_CFG_GET_FLD(attr, name) \
208+
_ATTR_CFG_GET_FLD(attr, \
209+
ATTR_CFG_FLD_##name##_CFG, \
210+
ATTR_CFG_FLD_##name##_LO, \
211+
ATTR_CFG_FLD_##name##_HI)
212+
193213
GEN_PMU_FORMAT_ATTR(mask);
194214
GEN_PMU_FORMAT_ATTR(match);
195215
GEN_PMU_FORMAT_ATTR(invert);

0 commit comments

Comments
 (0)