Skip to content

Commit ebb11d1

Browse files
Tzung-Bi Shihbroonie
authored andcommitted
ASoC: mediatek: mt8183-da7219: fix wrong ops for I2S3
DA7219 uses I2S2 and I2S3 for input and output respectively. Commit 9e30251 ("ASoC: mediatek: mt8183-da7219: support machine driver with rt1015") introduces a bug that: - If using I2S2 solely, MCLK to DA7219 is 256FS. - If using I2S3 solely, MCLK to DA7219 is 128FS. - If using I2S3 first and then I2S2, the MCLK changes from 128FS to 256FS. As a result, no sound output to the headset. Also no sound input from the headset microphone. Both I2S2 and I2S3 should set MCLK to 256FS. Fixes the wrong ops for I2S3. Fixes: 9e30251 ("ASoC: mediatek: mt8183-da7219: support machine driver with rt1015") Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> Link: https://lore.kernel.org/r/20201006101252.1890385-1-tzungbi@google.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 2044161 commit ebb11d1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ static int mt8183_da7219_max98357_dev_probe(struct platform_device *pdev)
673673
if (card == &mt8183_da7219_max98357_card) {
674674
dai_link->be_hw_params_fixup =
675675
mt8183_i2s_hw_params_fixup;
676-
dai_link->ops = &mt8183_mt6358_i2s_ops;
676+
dai_link->ops = &mt8183_da7219_i2s_ops;
677677
dai_link->cpus = i2s3_max98357a_cpus;
678678
dai_link->num_cpus =
679679
ARRAY_SIZE(i2s3_max98357a_cpus);

0 commit comments

Comments
 (0)