Skip to content

Commit ebb8308

Browse files
hormskuba-moo
authored andcommitted
gve: Avoid unnecessary use of comma operator
Although it does not seem to have any untoward side-effects, the use of ';' to separate to assignments seems more appropriate than ','. Flagged by clang-18 -Wcomma No functional change intended. Compile tested only. Reviewed-by: Shailend Chand <shailend@google.com> Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com> Signed-off-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20240508-gve-comma-v2-1-1ac919225f13@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent b9d5f57 commit ebb8308

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/google/gve/gve_adminq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -650,9 +650,9 @@ static void gve_adminq_get_create_rx_queue_cmd(struct gve_priv *priv,
650650
GVE_RAW_ADDRESSING_QPL_ID : rx->data.qpl->id;
651651

652652
cmd->create_rx_queue.rx_desc_ring_addr =
653-
cpu_to_be64(rx->desc.bus),
653+
cpu_to_be64(rx->desc.bus);
654654
cmd->create_rx_queue.rx_data_ring_addr =
655-
cpu_to_be64(rx->data.data_bus),
655+
cpu_to_be64(rx->data.data_bus);
656656
cmd->create_rx_queue.index = cpu_to_be32(queue_index);
657657
cmd->create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
658658
cmd->create_rx_queue.packet_buffer_size = cpu_to_be16(rx->packet_buffer_size);

0 commit comments

Comments
 (0)