Skip to content

Commit ebb9d3c

Browse files
committed
firewire: core: correct range of block for case of switch statement
A commit d8527ca ("firewire: cdev: implement new event to notify response subaction with time stamp") adds an additional case, FW_CDEV_EVENT_RESPONSE2, into switch statement in complete_transaction(). However, the range of block is beyond to the case label and reaches neibour default label. This commit corrects the range of block. Fortunately, it has few impacts in practice since the local variable in the scope under the label is not used in codes under default label. Fixes: d8527ca ("firewire: cdev: implement new event to notify response subaction with time stamp") Link: https://lore.kernel.org/r/20240810070403.36801-1-o-takashi@sakamocchi.jp Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
1 parent e4c8b80 commit ebb9d3c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/firewire/core-cdev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,11 +589,11 @@ static void complete_transaction(struct fw_card *card, int rcode, u32 request_ts
589589
queue_event(client, &e->event, rsp, sizeof(*rsp) + rsp->length, NULL, 0);
590590

591591
break;
592+
}
592593
default:
593594
WARN_ON(1);
594595
break;
595596
}
596-
}
597597

598598
/* Drop the idr's reference */
599599
client_put(client);

0 commit comments

Comments
 (0)