Skip to content

Commit ebc0ded

Browse files
committed
drm/msm: don't clean up priv->kms prematurely
MSM display drivers provide kms structure allocated during probe(). Don't clean up priv->kms field in case of an error. Otherwise probe functions might fail after KMS probe deferral. Fixes: a2ab5d5 ("drm/msm: allow passing struct msm_kms to msm_drv_probe()") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Fixes: 506efcb ("drm/msm: carve out KMS code from msm_drv.c") Patchwork: https://patchwork.freedesktop.org/patch/590411/ Link: https://lore.kernel.org/r/20240420-mdp4-fixes-v1-1-96a70f64fa85@linaro.org
1 parent b34a740 commit ebc0ded

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/gpu/drm/msm/msm_kms.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ int msm_drm_kms_init(struct device *dev, const struct drm_driver *drv)
244244
ret = priv->kms_init(ddev);
245245
if (ret) {
246246
DRM_DEV_ERROR(dev, "failed to load kms\n");
247-
priv->kms = NULL;
248247
return ret;
249248
}
250249

0 commit comments

Comments
 (0)