Skip to content

Commit ebfd448

Browse files
sulixshuahkh
authored andcommitted
kunit: tool: Fix spelling of "diagnostic" in kunit_parser
Various helper functions were misspelling "diagnostic" in their names. It finally got annoying, so fix it. Signed-off-by: David Gow <davidgow@google.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Tested-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
1 parent 65a4e52 commit ebfd448

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

tools/testing/kunit/kunit_parser.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ def print_log(log):
9797

9898
TAP_ENTRIES = re.compile(r'^(TAP|[\s]*ok|[\s]*not ok|[\s]*[0-9]+\.\.[0-9]+|[\s]*#).*$')
9999

100-
def consume_non_diagnositic(lines: List[str]) -> None:
100+
def consume_non_diagnostic(lines: List[str]) -> None:
101101
while lines and not TAP_ENTRIES.match(lines[0]):
102102
lines.pop(0)
103103

104-
def save_non_diagnositic(lines: List[str], test_case: TestCase) -> None:
104+
def save_non_diagnostic(lines: List[str], test_case: TestCase) -> None:
105105
while lines and not TAP_ENTRIES.match(lines[0]):
106106
test_case.log.append(lines[0])
107107
lines.pop(0)
@@ -113,7 +113,7 @@ def save_non_diagnositic(lines: List[str], test_case: TestCase) -> None:
113113
OK_NOT_OK_MODULE = re.compile(r'^(ok|not ok) ([0-9]+) - (.*)$')
114114

115115
def parse_ok_not_ok_test_case(lines: List[str], test_case: TestCase) -> bool:
116-
save_non_diagnositic(lines, test_case)
116+
save_non_diagnostic(lines, test_case)
117117
if not lines:
118118
test_case.status = TestStatus.TEST_CRASHED
119119
return True
@@ -139,7 +139,7 @@ def parse_ok_not_ok_test_case(lines: List[str], test_case: TestCase) -> bool:
139139
DIAGNOSTIC_CRASH_MESSAGE = re.compile(r'^[\s]+# .*?: kunit test case crashed!$')
140140

141141
def parse_diagnostic(lines: List[str], test_case: TestCase) -> bool:
142-
save_non_diagnositic(lines, test_case)
142+
save_non_diagnostic(lines, test_case)
143143
if not lines:
144144
return False
145145
line = lines[0]
@@ -155,7 +155,7 @@ def parse_diagnostic(lines: List[str], test_case: TestCase) -> bool:
155155

156156
def parse_test_case(lines: List[str]) -> Optional[TestCase]:
157157
test_case = TestCase()
158-
save_non_diagnositic(lines, test_case)
158+
save_non_diagnostic(lines, test_case)
159159
while parse_diagnostic(lines, test_case):
160160
pass
161161
if parse_ok_not_ok_test_case(lines, test_case):
@@ -166,7 +166,7 @@ def parse_test_case(lines: List[str]) -> Optional[TestCase]:
166166
SUBTEST_HEADER = re.compile(r'^[\s]+# Subtest: (.*)$')
167167

168168
def parse_subtest_header(lines: List[str]) -> Optional[str]:
169-
consume_non_diagnositic(lines)
169+
consume_non_diagnostic(lines)
170170
if not lines:
171171
return None
172172
match = SUBTEST_HEADER.match(lines[0])
@@ -179,7 +179,7 @@ def parse_subtest_header(lines: List[str]) -> Optional[str]:
179179
SUBTEST_PLAN = re.compile(r'[\s]+[0-9]+\.\.([0-9]+)')
180180

181181
def parse_subtest_plan(lines: List[str]) -> Optional[int]:
182-
consume_non_diagnositic(lines)
182+
consume_non_diagnostic(lines)
183183
match = SUBTEST_PLAN.match(lines[0])
184184
if match:
185185
lines.pop(0)
@@ -202,7 +202,7 @@ def max_status(left: TestStatus, right: TestStatus) -> TestStatus:
202202
def parse_ok_not_ok_test_suite(lines: List[str],
203203
test_suite: TestSuite,
204204
expected_suite_index: int) -> bool:
205-
consume_non_diagnositic(lines)
205+
consume_non_diagnostic(lines)
206206
if not lines:
207207
test_suite.status = TestStatus.TEST_CRASHED
208208
return False
@@ -235,7 +235,7 @@ def bubble_up_test_case_errors(test_suite: TestSuite) -> TestStatus:
235235
def parse_test_suite(lines: List[str], expected_suite_index: int) -> Optional[TestSuite]:
236236
if not lines:
237237
return None
238-
consume_non_diagnositic(lines)
238+
consume_non_diagnostic(lines)
239239
test_suite = TestSuite()
240240
test_suite.status = TestStatus.SUCCESS
241241
name = parse_subtest_header(lines)
@@ -264,7 +264,7 @@ def parse_test_suite(lines: List[str], expected_suite_index: int) -> Optional[Te
264264
TAP_HEADER = re.compile(r'^TAP version 14$')
265265

266266
def parse_tap_header(lines: List[str]) -> bool:
267-
consume_non_diagnositic(lines)
267+
consume_non_diagnostic(lines)
268268
if TAP_HEADER.match(lines[0]):
269269
lines.pop(0)
270270
return True
@@ -274,7 +274,7 @@ def parse_tap_header(lines: List[str]) -> bool:
274274
TEST_PLAN = re.compile(r'[0-9]+\.\.([0-9]+)')
275275

276276
def parse_test_plan(lines: List[str]) -> Optional[int]:
277-
consume_non_diagnositic(lines)
277+
consume_non_diagnostic(lines)
278278
match = TEST_PLAN.match(lines[0])
279279
if match:
280280
lines.pop(0)
@@ -286,7 +286,7 @@ def bubble_up_suite_errors(test_suite_list: List[TestSuite]) -> TestStatus:
286286
return bubble_up_errors(lambda x: x.status, test_suite_list)
287287

288288
def parse_test_result(lines: List[str]) -> TestResult:
289-
consume_non_diagnositic(lines)
289+
consume_non_diagnostic(lines)
290290
if not lines or not parse_tap_header(lines):
291291
return TestResult(TestStatus.NO_TESTS, [], lines)
292292
expected_test_suite_num = parse_test_plan(lines)

0 commit comments

Comments
 (0)