Skip to content

Commit ec0dd36

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: cros_ec_lightbar: Fix response size initialization
Commit 1e7913f ("platform/chrome: cros_ec_lightbar: Reduce ligthbar get version command") meant to set smaller values for both request and response sizes. However, it incorrectly assigned the response size to the `result` field instead of `insize`. Fix it. Reported-by: Gwendal Grignou <gwendal@google.com> Closes: https://lore.kernel.org/chrome-platform/CAMHSBOVrrYaB=1nEqZk09VkczCrj=6B-P8Fe29TpPdSDgT2CCQ@mail.gmail.com Fixes: 1e7913f ("platform/chrome: cros_ec_lightbar: Reduce ligthbar get version command") Link: https://lore.kernel.org/r/20260130040335.361997-1-tzungbi@kernel.org Reviewed-by: Gwendal Grignou <gwendal@google.com> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
1 parent a406566 commit ec0dd36

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/platform/chrome/cros_ec_lightbar.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ static int get_lightbar_version(struct cros_ec_dev *ec,
126126
param = (struct ec_params_lightbar *)msg->data;
127127
param->cmd = LIGHTBAR_CMD_VERSION;
128128
msg->outsize = sizeof(param->cmd);
129-
msg->result = sizeof(resp->version);
129+
msg->insize = sizeof(resp->version);
130130
ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
131131
if (ret < 0 && ret != -EINVAL) {
132132
ret = 0;

0 commit comments

Comments
 (0)