Skip to content

Commit ec4291f

Browse files
DispatchCoderafaeljw
authored andcommitted
ACPI: OSL: Add WQ_PERCPU to alloc_workqueue() users
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they’re needed and reducing noise when CPUs are isolated. This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> [ rjw: Subject adjustment ] Link: https://patch.msgid.link/20251030154739.262582-5-marco.crivellari@suse.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 87c21e2 commit ec4291f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/acpi/osl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1694,8 +1694,8 @@ acpi_status __init acpi_os_initialize(void)
16941694

16951695
acpi_status __init acpi_os_initialize1(void)
16961696
{
1697-
kacpid_wq = alloc_workqueue("kacpid", 0, 1);
1698-
kacpi_notify_wq = alloc_workqueue("kacpi_notify", 0, 0);
1697+
kacpid_wq = alloc_workqueue("kacpid", WQ_PERCPU, 1);
1698+
kacpi_notify_wq = alloc_workqueue("kacpi_notify", WQ_PERCPU, 0);
16991699
kacpi_hotplug_wq = alloc_ordered_workqueue("kacpi_hotplug", 0);
17001700
BUG_ON(!kacpid_wq);
17011701
BUG_ON(!kacpi_notify_wq);

0 commit comments

Comments
 (0)