io_uring: don't check req->file in io_fsync_prep()

axboe · axboe · commit ec858afda857 · 2022-04-03T17:07:54.000-06:00
This is a leftover from the really old days where we weren't able to
track and error early if we need a file and it wasn't assigned. Kill
the check.

Cc: stable@vger.kernel.org # v5.15+
Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/fs/io_uring.c b/fs/io_uring.c
@@ -4513,9 +4513,6 @@ static int io_fsync_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 {
 	struct io_ring_ctx *ctx = req->ctx;
 
-	if (!req->file)
-		return -EBADF;
-
 	if (unlikely(ctx->flags & IORING_SETUP_IOPOLL))
 		return -EINVAL;
 	if (unlikely(sqe->addr || sqe->ioprio || sqe->buf_index ||

Original file line number	Diff line number	Diff line change
`@@ -4513,9 +4513,6 @@ static int io_fsync_prep(struct io_kiocb req, const struct io_uring_sqe sqe)`
`4513`	`4513`	`{`
`4514`	`4514`	`struct io_ring_ctx *ctx = req->ctx;`
`4515`	`4515`
`4516`		`- if (!req->file)`
`4517`		`- return -EBADF;`
`4518`		`-`
`4519`	`4516`	`if (unlikely(ctx->flags & IORING_SETUP_IOPOLL))`
`4520`	`4517`	`return -EINVAL;`
`4521`	`4518`	`if (unlikely(sqe->addr \|\| sqe->ioprio \|\| sqe->buf_index \|\|`