xfrm: Fix leak of dev tracker

rleon · klassert · commit ec8f32ad9a65 · 2023-04-21T08:54:04.000+02:00
At the stage of direction checks, the netdev reference tracker is already initialized, but released with wrong *_put() call. Fixes: 919e43f ("xfrm: add an interface to offload policy") Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
@@ -378,7 +378,7 @@ int xfrm_dev_policy_add(struct net *net, struct xfrm_policy *xp,
 		break;
 	default:
 		xdo->dev = NULL;
-		dev_put(dev);
+		netdev_put(dev, &xdo->dev_tracker);
 		NL_SET_ERR_MSG(extack, "Unrecognized offload direction");
 		return -EINVAL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ int xfrm_dev_policy_add(struct net net, struct xfrm_policy xp,`
`378`	`378`	`break;`
`379`	`379`	`default:`
`380`	`380`	`xdo->dev = NULL;`
`381`		`- dev_put(dev);`
	`381`	`+ netdev_put(dev, &xdo->dev_tracker);`
`382`	`382`	`NL_SET_ERR_MSG(extack, "Unrecognized offload direction");`
`383`	`383`	`return -EINVAL;`
`384`	`384`	`}`