x86/xen: Remove undefined behavior in setup_features()

Julien Grall · jgross1 · commit ecb6237fa397 · 2022-06-21T16:36:11.000+02:00
1 << 31 is undefined. So switch to 1U << 31. Fixes: 5ead97c ("xen: Core Xen implementation") Signed-off-by: Julien Grall <jgrall@amazon.com> Reviewed-by: Juergen Gross <jgross@suse.com> Link: https://lore.kernel.org/r/20220617103037.57828-1-julien@xen.org Signed-off-by: Juergen Gross <jgross@suse.com>
diff --git a/drivers/xen/features.c b/drivers/xen/features.c
@@ -42,7 +42,7 @@ void xen_setup_features(void)
 		if (HYPERVISOR_xen_version(XENVER_get_features, &fi) < 0)
 			break;
 		for (j = 0; j < 32; j++)
-			xen_features[i * 32 + j] = !!(fi.submap & 1<<j);
+			xen_features[i * 32 + j] = !!(fi.submap & 1U << j);
 	}
 
 	if (xen_pv_domain()) {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ void xen_setup_features(void)`
`42`	`42`	`if (HYPERVISOR_xen_version(XENVER_get_features, &fi) < 0)`
`43`	`43`	`break;`
`44`	`44`	`for (j = 0; j < 32; j++)`
`45`		`- xen_features[i * 32 + j] = !!(fi.submap & 1<<j);`
	`45`	`+ xen_features[i * 32 + j] = !!(fi.submap & 1U << j);`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`if (xen_pv_domain()) {`