Skip to content

Commit ecfcae7

Browse files
lumagBartosz Golaszewski
authored andcommitted
power: sequencing: qcom-wcn: fix error path for VDDIO handling
In case getting VDDIO regulator returned an error, WCN power sequencing driver passes ret to dev_err_probe() as the error code, however it is known that ret is 0 at this point. Pass PTR_ERR(ctx->vddio) instead. Fixes: 0eb85f4 ("power: sequencing: qcom-wcn: add support for WCN39xx") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/aYXvQxKqmjP_sdCd@stanley.mountain/ Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://patch.msgid.link/20260207-fix-wcn39xx-v1-1-df0606108ce2@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
1 parent e1dccb4 commit ecfcae7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/power/sequencing/pwrseq-qcom-wcn.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ static int pwrseq_qcom_wcn_probe(struct platform_device *pdev)
489489
if (ctx->pdata->has_vddio) {
490490
ctx->vddio = devm_regulator_get(dev, "vddio");
491491
if (IS_ERR(ctx->vddio))
492-
return dev_err_probe(dev, ret, "Failed to get VDDIO\n");
492+
return dev_err_probe(dev, PTR_ERR(ctx->vddio), "Failed to get VDDIO\n");
493493
}
494494

495495
ctx->bt_gpio = devm_gpiod_get_optional(dev, "bt-enable", GPIOD_OUT_LOW);

0 commit comments

Comments
 (0)