Skip to content

Commit ed4d5ab

Browse files
Chun-Kuang HuAngeloGioacchino Del Regno
authored andcommitted
soc: mediatek: cmdq: Fix typo of CMDQ_JUMP_RELATIVE
For cmdq jump command, offset 0 means relative jump and offset 1 means absolute jump. cmdq_pkt_jump() is absolute jump, so fix the typo of CMDQ_JUMP_RELATIVE in cmdq_pkt_jump(). Fixes: 946f179 ("soc: mediatek: cmdq: add jump function") Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20240222154120.16959-2-chunkuang.hu@kernel.org Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent 4cece76 commit ed4d5ab

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/soc/mediatek/mtk-cmdq-helper.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
#define CMDQ_POLL_ENABLE_MASK BIT(0)
1515
#define CMDQ_EOC_IRQ_EN BIT(0)
1616
#define CMDQ_REG_TYPE 1
17-
#define CMDQ_JUMP_RELATIVE 1
17+
#define CMDQ_JUMP_RELATIVE 0
18+
#define CMDQ_JUMP_ABSOLUTE 1
1819

1920
struct cmdq_instruction {
2021
union {
@@ -397,7 +398,7 @@ int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr)
397398
struct cmdq_instruction inst = {};
398399

399400
inst.op = CMDQ_CODE_JUMP;
400-
inst.offset = CMDQ_JUMP_RELATIVE;
401+
inst.offset = CMDQ_JUMP_ABSOLUTE;
401402
inst.value = addr >>
402403
cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan);
403404
return cmdq_pkt_append_command(pkt, inst);

0 commit comments

Comments
 (0)