hfsplus: pretend special inodes as regular files

Tetsuo Handa · dubeyko · commit ed8889ca21b6 · 2026-01-06T12:41:50.000-08:00
Since commit af153bb ("vfs: catch invalid modes in may_open()") requires any inode be one of S_IFDIR/S_IFLNK/S_IFREG/S_IFCHR/S_IFBLK/ S_IFIFO/S_IFSOCK type, use S_IFREG for special inodes. Reported-by: syzbot <syzbot+895c23f6917da440ed0d@syzkaller.appspotmail.com> Closes: https://syzkaller.appspot.com/bug?extid=895c23f6917da440ed0d Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com> Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com> Link: https://lore.kernel.org/r/d0a07b1b-8b73-4002-8e29-e2bd56871262@I-love.SAKURA.ne.jp Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
@@ -53,6 +53,12 @@ static int hfsplus_system_read_inode(struct inode *inode)
 		return -EIO;
 	}
 
+	/*
+	 * Assign a dummy file type, for may_open() requires that
+	 * an inode has a valid file type.
+	 */
+	inode->i_mode = S_IFREG;
+
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,12 @@ static int hfsplus_system_read_inode(struct inode *inode)`
`53`	`53`	`return -EIO;`
`54`	`54`	`}`
`55`	`55`
	`56`	`+ /*`
	`57`	`+ * Assign a dummy file type, for may_open() requires that`
	`58`	`+ * an inode has a valid file type.`
	`59`	`+ */`
	`60`	`+ inode->i_mode = S_IFREG;`
	`61`	`+`
`56`	`62`	`return 0;`
`57`	`63`	`}`
`58`	`64`