ASoC: tas2781: Fix error code in tas2781_load_calibration()

Dan Carpenter · broonie · commit ed959833db7b · 2023-06-23T16:28:58.000+01:00
Return -EINVAL instead of success on this error path. Fixes: 915f5ea ("ASoC: tas2781: firmware lib") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/Message-Id: <729bb6b3-bc1d-4b3d-8b65-077a492c753c@moroto.mountain> Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
@@ -1924,6 +1924,7 @@ int tas2781_load_calibration(void *context, char *file_name,
 	if (!fw_entry->size) {
 		dev_err(tas_priv->dev, "%s: file read error: size = %lu\n",
 			__func__, (unsigned long)fw_entry->size);
+		ret = -EINVAL;
 		goto out;
 	}
 	fmw.size = fw_entry->size;

Original file line number	Diff line number	Diff line change
`@@ -1924,6 +1924,7 @@ int tas2781_load_calibration(void context, char file_name,`
`1924`	`1924`	`if (!fw_entry->size) {`
`1925`	`1925`	`dev_err(tas_priv->dev, "%s: file read error: size = %lu\n",`
`1926`	`1926`	`__func__, (unsigned long)fw_entry->size);`
	`1927`	`+ ret = -EINVAL;`
`1927`	`1928`	`goto out;`
`1928`	`1929`	`}`
`1929`	`1930`	`fmw.size = fw_entry->size;`