Skip to content

Commit edecdcc

Browse files
mtk-rogerlumbgg
authored andcommitted
soc: mediatek: mtk-svs: fix passing zero to 'PTR_ERR'
nvmem_cell_get() cannot return NULL so checking for NULL is wrong here. Signed-off-by: Roger Lu <roger.lu@mediatek.com> Fixes: 6c7174f ("soc: mediatek: mtk-svs: use svs get efuse common function") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/202302160720.N64SWT4l-lkp@intel.com/ Link: https://lore.kernel.org/r/20230216132543.814-1-roger.lu@mediatek.com Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
1 parent 2ba4e3b commit edecdcc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/soc/mediatek/mtk-svs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1726,7 +1726,7 @@ static int svs_get_efuse_data(struct svs_platform *svsp,
17261726
struct nvmem_cell *cell;
17271727

17281728
cell = nvmem_cell_get(svsp->dev, nvmem_cell_name);
1729-
if (IS_ERR_OR_NULL(cell)) {
1729+
if (IS_ERR(cell)) {
17301730
dev_err(svsp->dev, "no \"%s\"? %ld\n",
17311731
nvmem_cell_name, PTR_ERR(cell));
17321732
return PTR_ERR(cell);

0 commit comments

Comments
 (0)