Skip to content

Commit ee55f75

Browse files
YongWu-HFjoergroedel
authored andcommitted
iommu/mediatek: Add list_del in mtk_iommu_remove
Lack the list_del in the mtk_iommu_remove, and remove bus_set_iommu(*, NULL) since there may be several iommu HWs. we can not bus_set_iommu null when one iommu driver unbind. This could be a fix for mt2712 which support 2 M4U HW and list them. Fixes: 7c3a2ec ("iommu/mediatek: Merge 2 M4U HWs into one iommu domain") Signed-off-by: Yong Wu <yong.wu@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Link: https://lore.kernel.org/r/20220503071427.2285-6-yong.wu@mediatek.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 645b87c commit ee55f75

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/iommu/mtk_iommu.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -955,8 +955,7 @@ static int mtk_iommu_remove(struct platform_device *pdev)
955955
iommu_device_sysfs_remove(&data->iommu);
956956
iommu_device_unregister(&data->iommu);
957957

958-
if (iommu_present(&platform_bus_type))
959-
bus_set_iommu(&platform_bus_type, NULL);
958+
list_del(&data->list);
960959

961960
clk_disable_unprepare(data->bclk);
962961
device_link_remove(data->smicomm_dev, &pdev->dev);

0 commit comments

Comments
 (0)