Skip to content

Commit ee8ade4

Browse files
author
Maarten Lankhorst
committed
Revert "drm/syncobj: Fix handle <-> fd ioctls with dirty stack"
This reverts commit 2e3649e. The problem occurs when userspace is compiled against new headers with new members, but don't correctly initialise those new members. This is not a kernel problem, and should be fixed in userspace by correctly zero'ing all members. Cc: Rob Clark <robdclark@chromium.org> Cc: Julian Orth <ju.orth@gmail.com> Cc: Christian König <christian.koenig@amd.com> Cc: Michel Dänzer <michel.daenzer@mailbox.org> Reviewed-by: Christian König <christian.koenig@amd.com> Acked-by: Julian Orth <ju.orth@gmail.com> Link: https://patch.msgid.link/20260305113734.1309238-1-dev@lankhorst.se Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
1 parent 91d7e9d commit ee8ade4

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/drm_syncobj.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,7 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,
875875
return drm_syncobj_export_sync_file(file_private, args->handle,
876876
point, &args->fd);
877877

878-
if (point)
878+
if (args->point)
879879
return -EINVAL;
880880

881881
return drm_syncobj_handle_to_fd(file_private, args->handle,
@@ -909,7 +909,7 @@ drm_syncobj_fd_to_handle_ioctl(struct drm_device *dev, void *data,
909909
args->handle,
910910
point);
911911

912-
if (point)
912+
if (args->point)
913913
return -EINVAL;
914914

915915
return drm_syncobj_fd_to_handle(file_private, args->fd,

0 commit comments

Comments
 (0)