Skip to content

Commit ef248d9

Browse files
Sonarmantiwai
authored andcommitted
ALSA: hda/realtek: Add alc256-samsung-headphone fixup
This fixes the near-silence of the headphone jack on the ALC256-based Samsung Galaxy Book Flex Alpha (NP730QCJ). The magic verbs were found through trial and error, using known ALC298 hacks as inspiration. The fixup is auto-enabled only when the NP730QCJ is detected. It can be manually enabled using model=alc256-samsung-headphone. Signed-off-by: Matt Kramer <mccleetus@gmail.com> Link: https://lore.kernel.org/r/3168355.aeNJFYEL58@linus Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 17aaf01 commit ef248d9

2 files changed

Lines changed: 15 additions & 0 deletions

File tree

Documentation/sound/hd-audio/models.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,10 @@ alc-sense-combo
261261
huawei-mbx-stereo
262262
Enable initialization verbs for Huawei MBX stereo speakers;
263263
might be risky, try this at your own risk
264+
alc298-samsung-headphone
265+
Samsung laptops with ALC298
266+
alc256-samsung-headphone
267+
Samsung laptops with ALC256
264268

265269
ALC66x/67x/892
266270
==============

sound/pci/hda/patch_realtek.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6958,6 +6958,7 @@ enum {
69586958
ALC236_FIXUP_HP_MUTE_LED,
69596959
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF,
69606960
ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET,
6961+
ALC256_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET,
69616962
ALC295_FIXUP_ASUS_MIC_NO_PRESENCE,
69626963
ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS,
69636964
ALC269VC_FIXUP_ACER_HEADSET_MIC,
@@ -8286,6 +8287,14 @@ static const struct hda_fixup alc269_fixups[] = {
82868287
{ }
82878288
},
82888289
},
8290+
[ALC256_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET] = {
8291+
.type = HDA_FIXUP_VERBS,
8292+
.v.verbs = (const struct hda_verb[]) {
8293+
{ 0x20, AC_VERB_SET_COEF_INDEX, 0x08},
8294+
{ 0x20, AC_VERB_SET_PROC_COEF, 0x2fcf},
8295+
{ }
8296+
},
8297+
},
82898298
[ALC295_FIXUP_ASUS_MIC_NO_PRESENCE] = {
82908299
.type = HDA_FIXUP_PINS,
82918300
.v.pins = (const struct hda_pintbl[]) {
@@ -9099,6 +9108,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
90999108
SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8),
91009109
SND_PCI_QUIRK(0x144d, 0xc812, "Samsung Notebook Pen S (NT950SBE-X58)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
91019110
SND_PCI_QUIRK(0x144d, 0xc830, "Samsung Galaxy Book Ion (NT950XCJ-X716A)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
9111+
SND_PCI_QUIRK(0x144d, 0xc832, "Samsung Galaxy Book Flex Alpha (NP730QCJ)", ALC256_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
91029112
SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),
91039113
SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
91049114
SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
@@ -9445,6 +9455,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
94459455
{.id = ALC298_FIXUP_HUAWEI_MBX_STEREO, .name = "huawei-mbx-stereo"},
94469456
{.id = ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE, .name = "alc256-medion-headset"},
94479457
{.id = ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET, .name = "alc298-samsung-headphone"},
9458+
{.id = ALC256_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET, .name = "alc256-samsung-headphone"},
94489459
{.id = ALC255_FIXUP_XIAOMI_HEADSET_MIC, .name = "alc255-xiaomi-headset"},
94499460
{.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"},
94509461
{.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"},

0 commit comments

Comments
 (0)