Skip to content

Commit ef5bb8e

Browse files
jgunthorpejoergroedel
authored andcommitted
iommu/sun50i: Remove IOMMU_DOMAIN_IDENTITY
This driver treats IOMMU_DOMAIN_IDENTITY the same as UNMANAGED, which cannot possibly be correct. UNMANAGED domains are required to start out blocking all DMAs. This seems to be what this driver does as it allocates a first level 'dt' for the IO page table that is 0 filled. Thus UNMANAGED looks like a working IO page table, and so IDENTITY must be a mistake. Remove it. Fixes: 4100b8c ("iommu: Add Allwinner H6 IOMMU driver") Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Robin Murphy <robin.murphy@arm.com> Link: https://lore.kernel.org/r/0-v1-97f0adf27b5e+1f0-s50_identity_jgg@nvidia.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent e563cc0 commit ef5bb8e

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/iommu/sun50i-iommu.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,6 @@ static struct iommu_domain *sun50i_iommu_domain_alloc(unsigned type)
672672
struct sun50i_iommu_domain *sun50i_domain;
673673

674674
if (type != IOMMU_DOMAIN_DMA &&
675-
type != IOMMU_DOMAIN_IDENTITY &&
676675
type != IOMMU_DOMAIN_UNMANAGED)
677676
return NULL;
678677

0 commit comments

Comments
 (0)