Skip to content

Commit ef5dd8e

Browse files
dwmw2gregkh
authored andcommitted
hvc/xen: fix event channel handling for secondary consoles
The xencons_connect_backend() function allocates a local interdomain event channel with xenbus_alloc_evtchn(), then calls bind_interdomain_evtchn_to_irq_lateeoi() to bind to that port# on the *remote* domain. That doesn't work very well: (qemu) device_add xen-console,id=con1,chardev=pty0 [ 44.323872] xenconsole console-1: 2 xenbus_dev_probe on device/console/1 [ 44.323995] xenconsole: probe of console-1 failed with error -2 Fix it to use bind_evtchn_to_irq_lateeoi(), which does the right thing by just binding that *local* event channel to an irq. The backend will do the interdomain binding. This didn't affect the primary console because the setup for that is special — the toolstack allocates the guest event channel and the guest discovers it with HVMOP_get_param. Fixes: fe41518 ("xen/console: harden hvc_xen against event channel storms") Signed-off-by: David Woodhouse <dwmw@amazon.co.uk> Reviewed-by: Juergen Gross <jgross@suse.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20231020161529.355083-2-dwmw2@infradead.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 37058fd commit ef5dd8e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tty/hvc/hvc_xen.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ static int xencons_connect_backend(struct xenbus_device *dev,
433433
if (ret)
434434
return ret;
435435
info->evtchn = evtchn;
436-
irq = bind_interdomain_evtchn_to_irq_lateeoi(dev, evtchn);
436+
irq = bind_evtchn_to_irq_lateeoi(evtchn);
437437
if (irq < 0)
438438
return irq;
439439
info->irq = irq;

0 commit comments

Comments
 (0)