smb: propagate error code of extract_sharename()

e-orlova · smfrench · commit efc0b0bcffcb · 2023-08-30T23:38:49.000-05:00
In addition to the EINVAL, there may be an ENOMEM. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 70431bf ("cifs: Support fscache indexing rewrite") Signed-off-by: Katya Orlova <e.orlova@ispras.ru> Signed-off-by: Steve French <stfrench@microsoft.com>
diff --git a/fs/smb/client/fscache.c b/fs/smb/client/fscache.c
@@ -48,7 +48,7 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon)
 	sharename = extract_sharename(tcon->tree_name);
 	if (IS_ERR(sharename)) {
 		cifs_dbg(FYI, "%s: couldn't extract sharename\n", __func__);
-		return -EINVAL;
+		return PTR_ERR(sharename);
 	}
 
 	slen = strlen(sharename);

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon)`
`48`	`48`	`sharename = extract_sharename(tcon->tree_name);`
`49`	`49`	`if (IS_ERR(sharename)) {`
`50`	`50`	`cifs_dbg(FYI, "%s: couldn't extract sharename\n", __func__);`
`51`		`- return -EINVAL;`
	`51`	`+ return PTR_ERR(sharename);`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`slen = strlen(sharename);`