Skip to content

Commit f0243d2

Browse files
isilenceaxboe
authored andcommitted
io_uring/zcrx: convert to use netmem_desc
Convert zcrx to struct netmem_desc, and use struct net_iov::desc to access its fields instead of struct net_iov inner union alises. zcrx only directly reads niov->pp, so with this patch it doesn't depend on the union anymore. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Reviewed-by: Byungchul Park <byungchul@sk.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 5bd38e1 commit f0243d2

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

io_uring/zcrx.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -696,12 +696,12 @@ static void io_zcrx_return_niov(struct net_iov *niov)
696696
{
697697
netmem_ref netmem = net_iov_to_netmem(niov);
698698

699-
if (!niov->pp) {
699+
if (!niov->desc.pp) {
700700
/* copy fallback allocated niovs */
701701
io_zcrx_return_niov_freelist(niov);
702702
return;
703703
}
704-
page_pool_put_unrefed_netmem(niov->pp, netmem, -1, false);
704+
page_pool_put_unrefed_netmem(niov->desc.pp, netmem, -1, false);
705705
}
706706

707707
static void io_zcrx_scrub(struct io_zcrx_ifq *ifq)
@@ -815,7 +815,7 @@ static void io_zcrx_ring_refill(struct page_pool *pp,
815815
if (!page_pool_unref_and_test(netmem))
816816
continue;
817817

818-
if (unlikely(niov->pp != pp)) {
818+
if (unlikely(niov->desc.pp != pp)) {
819819
io_zcrx_return_niov(niov);
820820
continue;
821821
}
@@ -1082,13 +1082,15 @@ static int io_zcrx_recv_frag(struct io_kiocb *req, struct io_zcrx_ifq *ifq,
10821082
const skb_frag_t *frag, int off, int len)
10831083
{
10841084
struct net_iov *niov;
1085+
struct page_pool *pp;
10851086

10861087
if (unlikely(!skb_frag_is_net_iov(frag)))
10871088
return io_zcrx_copy_frag(req, ifq, frag, off, len);
10881089

10891090
niov = netmem_to_net_iov(frag->netmem);
1090-
if (!niov->pp || niov->pp->mp_ops != &io_uring_pp_zc_ops ||
1091-
io_pp_to_ifq(niov->pp) != ifq)
1091+
pp = niov->desc.pp;
1092+
1093+
if (!pp || pp->mp_ops != &io_uring_pp_zc_ops || io_pp_to_ifq(pp) != ifq)
10921094
return -EFAULT;
10931095

10941096
if (!io_zcrx_queue_cqe(req, niov, ifq, off + skb_frag_off(frag), len))

0 commit comments

Comments
 (0)