irqchip/mmp: Make icu_irq_chip variable static const

krzk · Thomas Gleixner · commit f0617176be5e · 2026-02-17T11:03:56.000+01:00
File-scope 'icu_irq_chip' is not used outside of this unit and is not modified anywhere, so make it static const to silence sparse warning: irq-mmp.c:139:17: warning: symbol 'icu_irq_chip' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Link: https://patch.msgid.link/20260216110449.160277-2-krzysztof.kozlowski@oss.qualcomm.com
diff --git a/drivers/irqchip/irq-mmp.c b/drivers/irqchip/irq-mmp.c
@@ -136,7 +136,7 @@ static void icu_unmask_irq(struct irq_data *d)
 	}
 }
 
-struct irq_chip icu_irq_chip = {
+static const struct irq_chip icu_irq_chip = {
 	.name		= "icu_irq",
 	.irq_mask	= icu_mask_irq,
 	.irq_mask_ack	= icu_mask_ack_irq,

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ static void icu_unmask_irq(struct irq_data *d)`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
`139`		`-struct irq_chip icu_irq_chip = {`
	`139`	`+static const struct irq_chip icu_irq_chip = {`
`140`	`140`	`.name = "icu_irq",`
`141`	`141`	`.irq_mask = icu_mask_irq,`
`142`	`142`	`.irq_mask_ack = icu_mask_ack_irq,`