ALSA: usb: fcp: Fix incorrect resp->opcode retrieval

tiwai · tiwai · commit f08cc80f69be · 2025-01-21T18:01:42.000+01:00
Fix a wrong conversion macro used for resp->opcode, which is __le32. Fixes: 46757a3 ("ALSA: FCP: Add Focusrite Control Protocol driver") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501212331.SaePSmsA-lkp@intel.com/ Link: https://patch.msgid.link/20250121170032.7236-3-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/usb/fcp.c b/sound/usb/fcp.c
@@ -266,7 +266,7 @@ static int fcp_usb(struct usb_mixer_interface *mixer, u32 opcode,
 	if (req->opcode != resp->opcode) {
 		usb_audio_err(mixer->chip,
 			      "FCP response %08x opcode mismatch %08x\n",
-			      opcode, le16_to_cpu(resp->opcode));
+			      opcode, le32_to_cpu(resp->opcode));
 		return -EINVAL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ static int fcp_usb(struct usb_mixer_interface *mixer, u32 opcode,`
`266`	`266`	`if (req->opcode != resp->opcode) {`
`267`	`267`	`usb_audio_err(mixer->chip,`
`268`	`268`	`"FCP response %08x opcode mismatch %08x\n",`
`269`		`- opcode, le16_to_cpu(resp->opcode));`
	`269`	`+ opcode, le32_to_cpu(resp->opcode));`
`270`	`270`	`return -EINVAL;`
`271`	`271`	`}`
`272`	`272`