Skip to content

Commit f0a0da1

Browse files
petrpavlurostedt
authored andcommitted
tracing: Fix checking of freed trace_event_file for hist files
The event_hist_open() and event_hist_poll() functions currently retrieve a trace_event_file pointer from a file struct by invoking event_file_data(), which simply returns file->f_inode->i_private. The functions then check if the pointer is NULL to determine whether the event is still valid. This approach is flawed because i_private is assigned when an eventfs inode is allocated and remains set throughout its lifetime. Instead, the code should call event_file_file(), which checks for EVENT_FILE_FL_FREED. Using the incorrect access function may result in the code potentially opening a hist file for an event that is being removed or becoming stuck while polling on this file. Correct the access method to event_file_file() in both functions. Cc: stable@vger.kernel.org Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Tom Zanussi <zanussi@kernel.org> Link: https://patch.msgid.link/20260219162737.314231-2-petr.pavlu@suse.com Fixes: 1bd13ed ("tracing/hist: Add poll(POLLIN) support on hist file") Signed-off-by: Petr Pavlu <petr.pavlu@suse.com> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent f4ff9f6 commit f0a0da1

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

kernel/trace/trace_events_hist.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5784,7 +5784,7 @@ static __poll_t event_hist_poll(struct file *file, struct poll_table_struct *wai
57845784

57855785
guard(mutex)(&event_mutex);
57865786

5787-
event_file = event_file_data(file);
5787+
event_file = event_file_file(file);
57885788
if (!event_file)
57895789
return EPOLLERR;
57905790

@@ -5822,7 +5822,7 @@ static int event_hist_open(struct inode *inode, struct file *file)
58225822

58235823
guard(mutex)(&event_mutex);
58245824

5825-
event_file = event_file_data(file);
5825+
event_file = event_file_file(file);
58265826
if (!event_file) {
58275827
ret = -ENODEV;
58285828
goto err;

0 commit comments

Comments
 (0)