Skip to content

Commit f10c23f

Browse files
aarontomlingregkh
authored andcommitted
tick/nohz: avoid showing '(null)' if nohz_full= not set
In the context of CONFIG_NO_HZ_FULL=y, tick_nohz_full_mask (of type cpumask_var_t) is initialised to 0. Memory is only allocated to the cpumask data structure, in tick_nohz_full_setup(), when Linux kernel boot-time parameter "nohz_full=" is correctly specified (see housekeeping_setup()). If "nohz_full=" is not set and an attempt is made to read /sys/devices/system/cpu/nohz_full, '(null)' can be displayed: ❯ cat /sys/devices/system/cpu/nohz_full (null) This patch changes the output to print a newline (or 0x0A) instead of '(null)', making it consistent with print_cpus_isolated() behaviour. Signed-off-by: Aaron Tomlin <atomlin@atomlin.com> Link: https://patch.msgid.link/20251011011830.6670-3-atomlin@atomlin.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 76987ba commit f10c23f

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/base/cpu.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,10 @@ static ssize_t nohz_full_show(struct device *dev,
305305
struct device_attribute *attr,
306306
char *buf)
307307
{
308-
return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(tick_nohz_full_mask));
308+
if (cpumask_available(tick_nohz_full_mask))
309+
return sysfs_emit(buf, "%*pbl\n",
310+
cpumask_pr_args(tick_nohz_full_mask));
311+
return sysfs_emit(buf, "\n");
309312
}
310313
static DEVICE_ATTR_RO(nohz_full);
311314
#endif

0 commit comments

Comments
 (0)