rv: Unlock on error path in rv_unregister_reactor()

Dan Carpenter · rostedt · commit f1a15b977ff8 · 2022-08-04T22:49:17.000-04:00
Unlock the "rv_interface_lock" mutex before returning. Link: https://lkml.kernel.org/r/YuvYzNfGMgV+PIhd@kili Fixes: 04acadc ("rv: Add runtime reactors interface") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c
@@ -329,6 +329,7 @@ int rv_register_reactor(struct rv_reactor *reactor)
 int rv_unregister_reactor(struct rv_reactor *reactor)
 {
 	struct rv_reactor_def *ptr, *next;
+	int ret = 0;
 
 	mutex_lock(&rv_interface_lock);
 
@@ -343,13 +344,14 @@ int rv_unregister_reactor(struct rv_reactor *reactor)
 				       ptr->reactor->name, ptr->counter);
 				printk(KERN_WARNING "rv: the rv_reactor %s cannot be removed\n",
 				       ptr->reactor->name);
-				return -EBUSY;
+				ret = -EBUSY;
+				break;
 			}
 		}
 	}
 
 	mutex_unlock(&rv_interface_lock);
-	return 0;
+	return ret;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -329,6 +329,7 @@ int rv_register_reactor(struct rv_reactor *reactor)`
`329`	`329`	`int rv_unregister_reactor(struct rv_reactor *reactor)`
`330`	`330`	`{`
`331`	`331`	`struct rv_reactor_def ptr, next;`
	`332`	`+ int ret = 0;`
`332`	`333`
`333`	`334`	`mutex_lock(&rv_interface_lock);`
`334`	`335`
`@@ -343,13 +344,14 @@ int rv_unregister_reactor(struct rv_reactor *reactor)`
`343`	`344`	`ptr->reactor->name, ptr->counter);`
`344`	`345`	`printk(KERN_WARNING "rv: the rv_reactor %s cannot be removed\n",`
`345`	`346`	`ptr->reactor->name);`
`346`		`- return -EBUSY;`
	`347`	`+ ret = -EBUSY;`
	`348`	`+ break;`
`347`	`349`	`}`
`348`	`350`	`}`
`349`	`351`	`}`
`350`	`352`
`351`	`353`	`mutex_unlock(&rv_interface_lock);`
`352`		`- return 0;`
	`354`	`+ return ret;`
`353`	`355`	`}`
`354`	`356`
`355`	`357`	`/*`