EDAC, pnd2: Correct misleading error message in mk_region_mask()

andy-shev · aegl · commit f1b0b1167f8b · 2023-12-05T13:04:57.000-08:00
The mask parameter is expected to be of a sequence of the set bits.
It does not mean it must be power of two (only single bit set).
Correct misleading error message.

Suggested-by: Qiuxu Zhuo &lt;qiuxu.zhuo@intel.com&gt;
Signed-off-by: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
Signed-off-by: Tony Luck &lt;tony.luck@intel.com&gt;
diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
@@ -329,7 +329,7 @@ static void mk_region_mask(char *name, struct region *rp, u64 base, u64 mask)
 		return;
 	}
 	if (mask != GENMASK_ULL(PND_MAX_PHYS_BIT, __ffs(mask))) {
-		pr_info(FW_BUG "MOT mask not power of two\n");
+		pr_info(FW_BUG "MOT mask is invalid\n");
 		return;
 	}
 	if (base & ~mask) {

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,7 @@ static void mk_region_mask(char name, struct region rp, u64 base, u64 mask)`
`329`	`329`	`return;`
`330`	`330`	`}`
`331`	`331`	`if (mask != GENMASK_ULL(PND_MAX_PHYS_BIT, __ffs(mask))) {`
`332`		`- pr_info(FW_BUG "MOT mask not power of two\n");`
	`332`	`+ pr_info(FW_BUG "MOT mask is invalid\n");`
`333`	`333`	`return;`
`334`	`334`	`}`
`335`	`335`	`if (base & ~mask) {`