drm/bridge: tc358768: Fix tc358768_ns_to_cnt()

tomba · robertfoss · commit f1dabbe64506 · 2023-09-20T13:48:47.000+02:00
The tc358768_ns_to_cnt() is, most likely, supposed to do a div-round-up operation, but it misses subtracting one from the dividend. Fix this by just using DIV_ROUND_UP(). Fixes: ff1ca63 ("drm/bridge: Add tc358768 driver") Reviewed-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> Tested-by: Maxim Schwalm <maxim.schwalm@gmail.com> # Asus TF700T Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Signed-off-by: Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230906-tc358768-v4-11-31725f008a50@ideasonboard.com
diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
@@ -630,7 +630,7 @@ static int tc358768_setup_pll(struct tc358768_priv *priv,
 
 static u32 tc358768_ns_to_cnt(u32 ns, u32 period_ps)
 {
-	return (ns * 1000 + period_ps) / period_ps;
+	return DIV_ROUND_UP(ns * 1000, period_ps);
 }
 
 static u32 tc358768_ps_to_ns(u32 ps)

Original file line number	Diff line number	Diff line change
`@@ -630,7 +630,7 @@ static int tc358768_setup_pll(struct tc358768_priv *priv,`
`630`	`630`
`631`	`631`	`static u32 tc358768_ns_to_cnt(u32 ns, u32 period_ps)`
`632`	`632`	`{`
`633`		`- return (ns * 1000 + period_ps) / period_ps;`
	`633`	`+ return DIV_ROUND_UP(ns * 1000, period_ps);`
`634`	`634`	`}`
`635`	`635`
`636`	`636`	`static u32 tc358768_ps_to_ns(u32 ps)`