Skip to content

Commit f1e47b8

Browse files
bbkzzvinodkoul
authored andcommitted
dmaengine: qcom_hidma: Use devm_platform_get_and_ioremap_resource()
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yangtao Li <frank.li@vivo.com> Link: https://lore.kernel.org/r/20230705081856.13734-2-frank.li@vivo.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent e93c47a commit f1e47b8

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

drivers/dma/qcom/hidma.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -765,17 +765,15 @@ static int hidma_probe(struct platform_device *pdev)
765765
pm_runtime_set_active(&pdev->dev);
766766
pm_runtime_enable(&pdev->dev);
767767

768-
trca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
769-
trca = devm_ioremap_resource(&pdev->dev, trca_resource);
768+
trca = devm_platform_get_and_ioremap_resource(pdev, 0, &trca_resource);
770769
if (IS_ERR(trca)) {
771-
rc = -ENOMEM;
770+
rc = PTR_ERR(trca);
772771
goto bailout;
773772
}
774773

775-
evca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 1);
776-
evca = devm_ioremap_resource(&pdev->dev, evca_resource);
774+
evca = devm_platform_get_and_ioremap_resource(pdev, 1, &evca_resource);
777775
if (IS_ERR(evca)) {
778-
rc = -ENOMEM;
776+
rc = PTR_ERR(evca);
779777
goto bailout;
780778
}
781779

@@ -785,7 +783,7 @@ static int hidma_probe(struct platform_device *pdev)
785783
*/
786784
chirq = platform_get_irq(pdev, 0);
787785
if (chirq < 0) {
788-
rc = -ENODEV;
786+
rc = chirq;
789787
goto bailout;
790788
}
791789

0 commit comments

Comments
 (0)