Skip to content

Commit f2539e1

Browse files
committed
Merge branch 'net-ipa-a-few-bug-fixes'
Alex Elder says: ==================== net: ipa: a few bug fixes This series fixes four minor bugs. The first two are things that sparse points out. All four are very simple and each patch should explain itself pretty well. ==================== Link: https://lore.kernel.org/r/20210201232609.3524451-1-elder@linaro.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2 parents 4ace7a6 + 113b6ea commit f2539e1

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/net/ipa/gsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ static void gsi_evt_ring_de_alloc_command(struct gsi *gsi, u32 evt_ring_id)
440440
static enum gsi_channel_state gsi_channel_state(struct gsi_channel *channel)
441441
{
442442
u32 channel_id = gsi_channel_id(channel);
443-
void *virt = channel->gsi->virt;
443+
void __iomem *virt = channel->gsi->virt;
444444
u32 val;
445445

446446
val = ioread32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id));

drivers/net/ipa/ipa_endpoint.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ static void ipa_endpoint_init_hdr_metadata_mask(struct ipa_endpoint *endpoint)
588588

589589
/* Note that HDR_ENDIANNESS indicates big endian header fields */
590590
if (endpoint->data->qmap)
591-
val = cpu_to_be32(IPA_ENDPOINT_QMAP_METADATA_MASK);
591+
val = (__force u32)cpu_to_be32(IPA_ENDPOINT_QMAP_METADATA_MASK);
592592

593593
iowrite32(val, endpoint->ipa->reg_virt + offset);
594594
}
@@ -1164,8 +1164,8 @@ static bool ipa_endpoint_status_skip(struct ipa_endpoint *endpoint,
11641164
return true;
11651165
if (!status->pkt_len)
11661166
return true;
1167-
endpoint_id = u32_get_bits(status->endp_dst_idx,
1168-
IPA_STATUS_DST_IDX_FMASK);
1167+
endpoint_id = u8_get_bits(status->endp_dst_idx,
1168+
IPA_STATUS_DST_IDX_FMASK);
11691169
if (endpoint_id != endpoint->endpoint_id)
11701170
return true;
11711171

drivers/net/ipa/ipa_mem.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ static void ipa_imem_exit(struct ipa *ipa)
336336

337337
size = iommu_unmap(domain, ipa->imem_iova, ipa->imem_size);
338338
if (size != ipa->imem_size)
339-
dev_warn(dev, "unmapped %zu IMEM bytes, expected %lu\n",
339+
dev_warn(dev, "unmapped %zu IMEM bytes, expected %zu\n",
340340
size, ipa->imem_size);
341341
} else {
342342
dev_err(dev, "couldn't get IPA IOMMU domain for IMEM\n");
@@ -440,7 +440,7 @@ static void ipa_smem_exit(struct ipa *ipa)
440440

441441
size = iommu_unmap(domain, ipa->smem_iova, ipa->smem_size);
442442
if (size != ipa->smem_size)
443-
dev_warn(dev, "unmapped %zu SMEM bytes, expected %lu\n",
443+
dev_warn(dev, "unmapped %zu SMEM bytes, expected %zu\n",
444444
size, ipa->smem_size);
445445

446446
} else {

0 commit comments

Comments
 (0)