Skip to content

Commit f2e78af

Browse files
namjaejeonsmfrench
authored andcommitted
ksmbd: fix uninitialized symbol 'pntsd_size'
No check for if "rc" is an error code for build_sec_desc(). This can cause problems with using uninitialized pntsd_size. Fixes: e2f3448 ("cifsd: add server-side procedures for SMB3") Cc: stable@vger.kernel.org # v5.15 Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent ef39946 commit f2e78af

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

fs/ksmbd/smb2pdu.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2962,6 +2962,10 @@ int smb2_open(struct ksmbd_work *work)
29622962
&pntsd_size, &fattr);
29632963
posix_acl_release(fattr.cf_acls);
29642964
posix_acl_release(fattr.cf_dacls);
2965+
if (rc) {
2966+
kfree(pntsd);
2967+
goto err_out;
2968+
}
29652969

29662970
rc = ksmbd_vfs_set_sd_xattr(conn,
29672971
user_ns,

0 commit comments

Comments
 (0)