Skip to content

Commit f30741c

Browse files
Kai-Heng Fengtiwai
authored andcommitted
ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
Commit 5aec989 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") is to solve recording issue met on AL236, by matching codec variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256. This match can be too broad and Mi Notebook Pro 2020 is broken by the patch. Instead, use codec ID to be narrow down the scope, in order to make ALC256 unaffected. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484 Fixes: 5aec989 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: <stable@vger.kernel.org> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Link: https://lore.kernel.org/r/20220330061335.1015533-1-kai.heng.feng@canonical.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 5e2baa0 commit f30741c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

sound/pci/hda/patch_realtek.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3617,8 +3617,8 @@ static void alc256_shutup(struct hda_codec *codec)
36173617
/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
36183618
* when booting with headset plugged. So skip setting it for the codec alc257
36193619
*/
3620-
if (spec->codec_variant != ALC269_TYPE_ALC257 &&
3621-
spec->codec_variant != ALC269_TYPE_ALC256)
3620+
if (codec->core.vendor_id != 0x10ec0236 &&
3621+
codec->core.vendor_id != 0x10ec0257)
36223622
alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
36233623

36243624
if (!spec->no_shutup_pins)

0 commit comments

Comments
 (0)