i2c: remove redundant condition

zoanana990 · Wolfram Sang · commit f311507c5336 · 2024-03-07T09:36:08.000+01:00
I2C_M_RD is defined as and guaranteed to be 1 and 'flag &amp; I2C_M_RD' is
one or zero. No need for an additional condition to obtain the value.

Signed-off-by: Hsin-Yu.Chen &lt;harry021633@gmail.com&gt;
Reviewed-by: Andi Shyti &lt;andi.shyti@kernel.org&gt;
[wsa: slightly updated commit message]
Signed-off-by: Wolfram Sang &lt;wsa+renesas@sang-engineering.com&gt;
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
 
 static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
 {
-	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
 }
 
 u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);

Original file line number	Diff line number	Diff line change
`@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)`
`931`	`931`
`932`	`932`	`static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)`
`933`	`933`	`{`
`934`		`- return (msg->addr << 1) \| (msg->flags & I2C_M_RD ? 1 : 0);`
	`934`	`+ return (msg->addr << 1) \| (msg->flags & I2C_M_RD);`
`935`	`935`	`}`
`936`	`936`
`937`	`937`	`u8 i2c_get_dma_safe_msg_buf(struct i2c_msg msg, unsigned int threshold);`