Skip to content

Commit f35e16e

Browse files
andy-shevAndi Shyti
authored andcommitted
i2c: designware: Remove dead code in AMD ISP case
The I²C bus shared with P-Unit is Intel only thing as far as I know. The AMD ISP driver has no relationship with P-Unit. Remove dead code that seems copied without much thinking. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Pratap Nirujogi <pratap.nirujogi@amd.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Andi Shyti <andi.shyti@kernel.org> Link: https://lore.kernel.org/r/20260129103439.187478-1-andriy.shevchenko@linux.intel.com
1 parent 5600722 commit f35e16e

1 file changed

Lines changed: 1 addition & 12 deletions

File tree

drivers/i2c/busses/i2c-designware-amdisp.c

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
static void amd_isp_dw_i2c_plat_pm_cleanup(struct dw_i2c_dev *i2c_dev)
1919
{
2020
pm_runtime_disable(i2c_dev->dev);
21-
22-
if (i2c_dev->shared_with_punit)
23-
pm_runtime_put_noidle(i2c_dev->dev);
2421
}
2522

2623
static inline u32 amd_isp_dw_i2c_get_clk_rate(struct dw_i2c_dev *i2c_dev)
@@ -79,9 +76,6 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev)
7976

8077
device_enable_async_suspend(&pdev->dev);
8178

82-
if (isp_i2c_dev->shared_with_punit)
83-
pm_runtime_get_noresume(&pdev->dev);
84-
8579
pm_runtime_enable(&pdev->dev);
8680
pm_runtime_get_sync(&pdev->dev);
8781

@@ -130,9 +124,6 @@ static int amd_isp_dw_i2c_plat_runtime_suspend(struct device *dev)
130124
{
131125
struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
132126

133-
if (i_dev->shared_with_punit)
134-
return 0;
135-
136127
i2c_dw_disable(i_dev);
137128
i2c_dw_prepare_clk(i_dev, false);
138129

@@ -161,9 +152,7 @@ static int amd_isp_dw_i2c_plat_runtime_resume(struct device *dev)
161152
if (!i_dev)
162153
return -ENODEV;
163154

164-
if (!i_dev->shared_with_punit)
165-
i2c_dw_prepare_clk(i_dev, true);
166-
155+
i2c_dw_prepare_clk(i_dev, true);
167156
i2c_dw_init(i_dev);
168157

169158
return 0;

0 commit comments

Comments
 (0)