mtd: cfi_cmdset_0002: remove redundant assignment to variable timeo

Colin Ian King · r-vignesh · commit f3907773d602 · 2021-04-08T00:13:19.000+05:30
The variable timeo is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> Link: https://lore.kernel.org/r/20210325174514.486272-1-colin.king@canonical.com Addresses-Coverity: ("Unused value")
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1653,7 +1653,7 @@ static int __xipram do_write_oneword_once(struct map_info *map,
 					  unsigned long adr, map_word datum,
 					  int mode, struct cfi_private *cfi)
 {
-	unsigned long timeo = jiffies + HZ;
+	unsigned long timeo;
 	/*
 	 * We use a 1ms + 1 jiffies generic timeout for writes (most devices
 	 * have a max write time of a few hundreds usec). However, we should

Original file line number	Diff line number	Diff line change
`@@ -1653,7 +1653,7 @@ static int __xipram do_write_oneword_once(struct map_info *map,`
`1653`	`1653`	`unsigned long adr, map_word datum,`
`1654`	`1654`	`int mode, struct cfi_private *cfi)`
`1655`	`1655`	`{`
`1656`		`- unsigned long timeo = jiffies + HZ;`
	`1656`	`+ unsigned long timeo;`
`1657`	`1657`	`/*`
`1658`	`1658`	`* We use a 1ms + 1 jiffies generic timeout for writes (most devices`
`1659`	`1659`	`* have a max write time of a few hundreds usec). However, we should`