Skip to content

Commit f3afd3f

Browse files
a3fShawn Guo
authored andcommitted
clk: imx6q: demote warning about pre-boot ldb_di_clk reparenting
Since 5d283b0 ("clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK"), the clock driver warns if ldb_di\d_sel is changed from reset value on system boot. This warning is printed even if the bootloader (or a previous kernel that did kexec) followed the correct procedure for glitch-free reparenting. As such systems are doing everything correctly, a warning is too harsh. Demote to a notice, so users are still alerted, but without cluttering a loglevel=5 boot. While at it, add the words "possible glitch" into the log message, to make it more user-friendly. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Reviewed-by: Fabio Estevam <festevam@gmail.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
1 parent 6f88ef3 commit f3afd3f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/clk/imx/clk-imx6q.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,10 +338,10 @@ static void init_ldb_clks(struct device_node *np, void __iomem *ccm_base)
338338
of_assigned_ldb_sels(np, &sel[0][3], &sel[1][3]);
339339

340340
for (i = 0; i < 2; i++) {
341-
/* Warn if a glitch might have been introduced already */
341+
/* Print a notice if a glitch might have been introduced already */
342342
if (sel[i][0] != 3) {
343-
pr_warn("ccm: ldb_di%d_sel already changed from reset value: %d\n",
344-
i, sel[i][0]);
343+
pr_notice("ccm: possible glitch: ldb_di%d_sel already changed from reset value: %d\n",
344+
i, sel[i][0]);
345345
}
346346

347347
if (sel[i][0] == sel[i][3])

0 commit comments

Comments
 (0)