xfs: Use generic_file_open()

Matthew Wilcox (Oracle) · dchinner · commit f3bf67c6c6fe · 2022-04-12T06:49:40.000+10:00
Remove the open-coded check of O_LARGEFILE.  This changes the errno
to be the same as other filesystems; it was changed generically in
2.6.24 but that fix skipped XFS.

Signed-off-by: Matthew Wilcox (Oracle) &lt;willy@infradead.org&gt;
Reviewed-by: Dave Chinner &lt;dchinner@redhat.com&gt;
Signed-off-by: Dave Chinner &lt;david@fromorbit.com&gt;
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
@@ -1167,12 +1167,10 @@ xfs_file_open(
 	struct inode	*inode,
 	struct file	*file)
 {
-	if (!(file->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS)
-		return -EFBIG;
 	if (xfs_is_shutdown(XFS_M(inode->i_sb)))
 		return -EIO;
 	file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC;
-	return 0;
+	return generic_file_open(inode, file);
 }
 
 STATIC int

Original file line number	Diff line number	Diff line change
`@@ -1167,12 +1167,10 @@ xfs_file_open(`
`1167`	`1167`	`struct inode *inode,`
`1168`	`1168`	`struct file *file)`
`1169`	`1169`	`{`
`1170`		`- if (!(file->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS)`
`1171`		`- return -EFBIG;`
`1172`	`1170`	`if (xfs_is_shutdown(XFS_M(inode->i_sb)))`
`1173`	`1171`	`return -EIO;`
`1174`	`1172`	`file->f_mode \|= FMODE_NOWAIT \| FMODE_BUF_RASYNC;`
`1175`		`- return 0;`
	`1173`	`+ return generic_file_open(inode, file);`
`1176`	`1174`	`}`
`1177`	`1175`
`1178`	`1176`	`STATIC int`