Skip to content

Commit f4e4003

Browse files
committed
Merge branch 'pci/controller/xilinx'
- Fix IRQ domain leak when MSI allocation fails (Haotian Zhang) * pci/controller/xilinx: PCI: xilinx: Fix INTx IRQ domain leak in error paths
2 parents bf1676e + f42b3c0 commit f4e4003

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

drivers/pci/controller/pcie-xilinx.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,9 +302,10 @@ static int xilinx_allocate_msi_domains(struct xilinx_pcie *pcie)
302302
return 0;
303303
}
304304

305-
static void xilinx_free_msi_domains(struct xilinx_pcie *pcie)
305+
static void xilinx_free_irq_domains(struct xilinx_pcie *pcie)
306306
{
307307
irq_domain_remove(pcie->msi_domain);
308+
irq_domain_remove(pcie->leg_domain);
308309
}
309310

310311
/* INTx Functions */
@@ -480,8 +481,10 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie *pcie)
480481
phys_addr_t pa = ALIGN_DOWN(virt_to_phys(pcie), SZ_4K);
481482

482483
ret = xilinx_allocate_msi_domains(pcie);
483-
if (ret)
484+
if (ret) {
485+
irq_domain_remove(pcie->leg_domain);
484486
return ret;
487+
}
485488

486489
pcie_write(pcie, upper_32_bits(pa), XILINX_PCIE_REG_MSIBASE1);
487490
pcie_write(pcie, lower_32_bits(pa), XILINX_PCIE_REG_MSIBASE2);
@@ -600,7 +603,7 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
600603

601604
err = pci_host_probe(bridge);
602605
if (err)
603-
xilinx_free_msi_domains(pcie);
606+
xilinx_free_irq_domains(pcie);
604607

605608
return err;
606609
}

0 commit comments

Comments
 (0)