Skip to content

Commit f5964ce

Browse files
krzkmathieupoirier
authored andcommitted
remoteproc: ti_k3_r5: Simplify with scoped for each OF child loop
Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20241011-remote-proc-dev-err-probe-v1-4-5abb4fc61eca@linaro.org Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent fa9f7ef commit f5964ce

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/remoteproc/ti_k3_r5_remoteproc.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1650,16 +1650,14 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
16501650
struct device *dev = &pdev->dev;
16511651
struct device_node *np = dev_of_node(dev);
16521652
struct platform_device *cpdev;
1653-
struct device_node *child;
16541653
struct k3_r5_core *core;
16551654
int ret;
16561655

1657-
for_each_available_child_of_node(np, child) {
1656+
for_each_available_child_of_node_scoped(np, child) {
16581657
cpdev = of_find_device_by_node(child);
16591658
if (!cpdev) {
16601659
ret = -ENODEV;
16611660
dev_err(dev, "could not get R5 core platform device\n");
1662-
of_node_put(child);
16631661
goto fail;
16641662
}
16651663

@@ -1668,7 +1666,6 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
16681666
dev_err(dev, "k3_r5_core_of_init failed, ret = %d\n",
16691667
ret);
16701668
put_device(&cpdev->dev);
1671-
of_node_put(child);
16721669
goto fail;
16731670
}
16741671

0 commit comments

Comments
 (0)